-
-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] wgpu: Update bindings from v22.1.0.1 to v24.0.0.1 #4888
base: master
Are you sure you want to change the base?
Conversation
…vided by wgpu-native
…his won't work until a new wgpu-native release is created with the fix.
Hey @Valakor, argh, always a pain when people do the same work at the same time... We will be going with my PR for the update, mainly because it also updated wgpu.js. I do like that you've brought over doc comments. Although we do not really use the commenting conventions you used. Other than that the PRs look pretty similar. If you have any suggestions or things you think were missed on my end please let me know. |
I'm marking this Draft because of a few design questions, and because I haven't yet figured out how to update
wgpu.js
properly.Notable differences and things I'd like feedback on:
wgpuSurfacePresent
,wgpuAdapterGetInfo
, andwgpuSurfaceGetCapabilities
.Status
only has the valuesSuccess
andError
at the moment. This fits nicely with the (value, ok) return idiom in Odin if I were to translate the API values to bools instead, but would break if Status ever gains additional values.StringView
type. I've added some helpers (extra constants, creation functions, and a user formatter) that don't exist in the actual WGPU API but I wasn't sure what general policy was on API extras like these.wgpu.js
. Maybe @laytan has thoughts here? Some notable changes:StringView
typeu64
instead ofu32